-
Notifications
You must be signed in to change notification settings - Fork 29
Miscellaneous resilience improvements #2358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miscellaneous resilience improvements #2358
Conversation
This zone does not have support for Arm VMs, which is causing it to fail the entire workflow when we rollover to it.
This is a newer approach to break out of loops in ansible which is closer to what we originally intended.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2358 +/- ##
=======================================
Coverage 28.83% 28.83%
=======================================
Files 96 96
Lines 5799 5799
Branches 2551 2551
=======================================
Hits 1672 1672
Misses 3408 3408
Partials 719 719
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
df4c39b to
b42cb48
Compare
| - us-central1-a | ||
| - us-central1-b | ||
| - us-central1-c | ||
| - us-central1-f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - us-central1-f | |
| - us-central1-f | |
| - us-central1-d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ gcloud compute machine-types list --filter="name=t2a-standard-2 AND zone~'^us-'" --format="value(zone)"
us-central1-a
us-central1-b
us-central1-f
us-central1-d
|
So the changes in this PR are not really doing what I intended them to do. The current state on master is that ansible will create a VM on The intention of this PR was to attempt to remove the VM once it fails, this can be achieved with a |
Co-authored-by: Robby Cochran <[email protected]>
Description
Some improvements have been made to our ansible playbooks, namely:
us-central1-czone, since this one doesn't have Arm VM support.break_whenloop control, this is closer to our original intent.Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
CI should be enough.